mathiasbynens / punycode.js

A robust Punycode converter that fully complies to RFC 3492 and RFC 5891.
https://mths.be/punycode
MIT License
1.59k stars 158 forks source link

Missing releases. Missing tag for `punycode@2.3.0`. #131

Closed MikeMcC399 closed 8 months ago

MikeMcC399 commented 10 months ago

Please add the releases after 2.0.0 to the GitHub releases section.

At the moment https://github.com/mathiasbynens/punycode.js/releases contains only

although v2.0.0 is not the latest released version.

The releases after v2.0.0 are not listed under releases.

These are the current v2 tags in the repo:

$ git tag -l v2*
v2.0.0
v2.0.1
v2.1.0
v2.1.1
v2.2.0
v2.2.1
v2.2.2

According to npm, the latest release to the npm registry is punycode@2.3.0

$ npm view punycode.js dist-tags
{ latest: '2.3.0' }

Suggestions

  1. Add a tag v2.3.0 to https://github.com/mathiasbynens/punycode.js/commit/2047fe7e4ddcece709b388a569be51c62045535e and mark it in GitHub as the latest release
  2. Mark the following tags as released in GitHub
    v2.0.1
    v2.1.0
    v2.1.1
    v2.2.0
    v2.2.1
    v2.2.2

See GitHub docs Managing releases in a repository.

mathiasbynens commented 10 months ago

Thanks! I ran git tag v2.3.0 2047fe7e4ddcece709b388a569be51c62045535e && git push --tags. I’ll leave this open to deal with the other tags.

MikeMcC399 commented 10 months ago

@mathiasbynens

Thanks for picking this up! I see you've also released v2.3.1 so the original post is no longer exactly accurate although the general principle still applies.

MikeMcC399 commented 10 months ago

Current state

Tag Listed in Releases
v2.0.0 YES
v2.0.1
v2.1.0
v2.1.1
v2.2.0
v2.2.1
v2.2.2
v2.3.0
v2.3.1 YES
MikeMcC399 commented 8 months ago

@mathiasbynens

If you are not planning to add the intermediate releases from v2.0.1 to v2.3.0 inclusive to the https://github.com/mathiasbynens/punycode.js/releases page, then I guess we can close this issue.

mathiasbynens commented 8 months ago

Hi Mike, thanks for your patience. The missing releases should be added now.

MikeMcC399 commented 8 months ago

Hi @mathiasbynens

The missing releases should be added now.

Thank you for resolving this issue!