ci: automatically test on all LTS node versions - Githubissues

mathiasbynens / punycode.js

A robust Punycode converter that fully complies to RFC 3492 and RFC 5891.

https://mths.be/punycode

MIT License

1.59k stars 158 forks source link

ci: automatically test on all LTS node versions #134

Open msimerson opened 5 months ago

msimerson commented 5 months ago

automatically test on all LTS node versions (currently: 18, 20)
- example for testing on extra versions (21)
adds windows testing (win tests take ~30 seconds longer)
replace codecov dependency (in package.json) with codecov-action (in GHA workflow)
- has working config for codecov & coveralls (commented out)
test: prefix mocha with npx
- no need to declare dependency, gets installed automatically when tests are run
- pairs nicely with #135

I'm happy to amend this PR in any way that suits the maintainer(s).

fixes #119

Previews

Screenshot 2024-03-26 at 5 53 07 PM

--

Screenshot 2024-03-26 at 6 29 52 PM

msimerson commented 4 months ago

Is there anything I can do to nudge this along?