mathiasfc / learning-english

A simple project, which aims to help english language students to practice the language, through visual and auditory stimuli.
https://learning-english.vercel.app/
MIT License
14 stars 12 forks source link

added auto advance settings state and slider #12

Closed ewatch closed 2 years ago

ewatch commented 2 years ago

Description

This PR adds the slider to the settings modal. Additional it adds the state to the SettingsContext to be used in the App for controlling the speed of change to jump to the next word.

Fixes #3

Type of change

Please delete options that are not relevant.

How Has This Been Tested?

By running the application enabling / disabling auto advance and changing the interval back and forth.

Checklist:

welcome[bot] commented 2 years ago

Hello there! 👋 Welcome to this project! 💖 Thank you and congrats 🎉🎉 for opening your first pull request! ✨ Don't forget to star ⭐ this repo to stay updated! 😄

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-english ✅ Ready (Inspect) Visit Preview Oct 29, 2022 at 9:04AM (UTC)
ewatch commented 2 years ago

Can't see what the problem is, @mathiasfc can please show the error message ?

mathiasfc commented 2 years ago

Can't see what the problem is, @mathiasfc can please show the error message ?

Sure, image

Maybe you can see the error running: npm run type-check or npm run lint :thinking:

ewatch commented 2 years ago

@mathiasfc Thank you for posting the error message, didn't think about running the linting locally, sorry. Okay i think I fixed the issues. Please propose a better fix if it's not acceptable for the ReactChange Event handler.

ewatch commented 2 years ago

@mathiasfc would be great if this could be reviewed and merged

welcome[bot] commented 2 years ago

Congrats on merging your first pull request! 🎉🎉