search

mathiasfc / learning-english

A simple project, which aims to help english language students to practice the language, through visual and auditory stimuli.
https://learning-english.vercel.app/
MIT License
11 stars 11 forks source link

Fixed typo in settings #16

Closed amittri1025 closed 1 year ago

amittri1025 commented 1 year ago

Description

There's a error in Settings where on turning on Male Voice , female voice plays. So, I changed the name to Female Voice, now things make sense there.

image

Fixes #15

welcome[bot] commented 1 year ago

Hello there! 👋 Welcome to this project! 💖 Thank you and congrats 🎉🎉 for opening your first pull request! ✨ Don't forget to star ⭐ this repo to stay updated! 😄

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
learning-english ✅ Ready (Inspect) Visit Preview Oct 28, 2022 at 0:01AM (UTC)
amittri1025 commented 1 year ago

kindly merge this pr with hacktoberfest label

mathiasfc commented 1 year ago

@balayokesh @amittri1025 Sorry for the delay, I had some problems here.

Guys, I think the voices of Web_Speech_API changes according to OS or device, I really don't know.

Here (Ubuntu 22), the production version works well, the voice is correct. But on my phone (Android), I had only female voices, even if male voice is enabled.

So, I need to study the API better and understand how to solve this, for now I will not accept the PR.