mathiasfrey / ecrterm

Python ZVT 700 interface (electronic cash registers)
GNU Lesser General Public License v3.0
34 stars 31 forks source link

My py3-ecrterm fork #10

Open karolyi opened 6 years ago

karolyi commented 6 years ago

Hey guys,

just to inform you, I have implemented the TCP transport and upgraded the code here and there in my fork.

I have a python3.6+ only version, travis tests, enforced PEP8 checks, and the aforementioned TCP transport which 'works for me', but is still a work in progress. I had to fork it, but I do not plan to release it on pypi until I get the approval from here. Although I'm keeping that fork to have it working in my project.

Anyone is welcome to use it: https://github.com/karolyi/py3-ecrterm

raphaelm commented 6 years ago

FYI, I also maintain a Python3.6 fork that fixed a number of things around passwords and configuration: https://github.com/raphaelm/ecrterm/tree/python3

karolyi commented 6 years ago

@raphaelm, if you look at my fork, your changes are included. :)

raphaelm commented 6 years ago

Great :)

g4borg commented 1 year ago

sorry guys, just stumbled on this topic here again by accident

if you are still maintaining it karolyi on your offsite branch, then I am fine with releasing it more broadly

If mathias does not object, which I doubt, and given I was the original author, I think I can decide this.

karolyi commented 1 year ago

Hey @g4borg,

yes the project is maintained offsite. The offsite repo is still maintained at https://gitea.ksol.io/karolyi/py3-ecrterm, you can register there, I can give you commit access then. However I think you'll need a review before adding stuff since there were beginnings of TLV parsing as far as I can remember, which I merged as well. Those changes haven't been tested out. The py3 branch (should be set as default) contains them.

Let me know when you registered over there, so I can give you commit access.

mborus commented 1 year ago

@karolyi - just looked at your gitea fork. Does it come with any documentation or a example, how to use the code?

karolyi commented 1 year ago

@mborus I think https://gitea.ksol.io/karolyi/py3-ecrterm/src/branch/py3/test_pt.py should be it, but I haven't touched this codebase for a long time, since the project I built with it works ever since.

mborus commented 1 year ago

@karolyi Thanks for the quick reply - that looks promising. I'll try it out next time I get my hands on ZVT terminal hardware. I wrote my own limited interface, but am not happy with it so I'm looking for alternatives.