search

mathiask88 / node-snap7

node.js wrapper for snap7
MIT License
163 stars 59 forks source link

npm install fails with with Node v12.5.0 #60

Closed MarcusCalidus closed 5 years ago

MarcusCalidus commented 5 years ago

Hi,

upon installing node-snap7@1.0.2 via npm i on Darwin 18.6.0 I receive following error:

../src/node_snap7_client.cpp:710:53: error: too few arguments to function call, single argument 'context' was not specified
    Nan::NewInstance(constructorHandle->GetFunction()).ToLocalChecked());
                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
/Users/marcowarm/.node-gyp/12.5.0/include/node/v8.h:5948:3: note: 'GetFunction' declared here
  V8_WARN_UNUSED_RESULT MaybeLocal<Function> GetFunction(
  ^
/Users/marcowarm/.node-gyp/12.5.0/include/node/v8config.h:351:31: note: expanded from macro 'V8_WARN_UNUSED_RESULT'
#define V8_WARN_UNUSED_RESULT __attribute__((warn_unused_result))
                              ^
2 errors generated.
make: *** [Release/obj.target/node_snap7/src/node_snap7_client.o] Error 1
mathiask88 commented 5 years ago

fixed in 1.0.3