search

mathiask88 / node-snap7

node.js wrapper for snap7
MIT License
166 stars 59 forks source link

Node.js 20 compatibility #93

Closed Apollon77 closed 1 year ago

Apollon77 commented 1 year ago

This PR is upgrading dependencies and also adds GitHub actions businging. I found out that Node.js 4 and 6 would no longer install so I removed it also frpm the package.json.

Please release a version to make the great library compatible with Node.js 20 too.

because I tried several things maybe better to squash&merge :-)

mathiask88 commented 1 year ago

I'll have a look in the next days. I also had some github actions changes locally. Hope a fix till end of the week works for you :)

Apollon77 commented 1 year ago

Awesome thank you!

Apollon77 commented 1 year ago

PS: If you like just remove my GHA ... it was mainly also for me to proof the "dep increase is enough" solution as working. So also ok for me if you take relevant changes and do not merge.

mathiask88 commented 1 year ago

see #94