mathiasverraes / jdump

J!Dump is a very easy to use debugging extension for Joomla developers and template designers. Download links below.
http://twitter.com/mathiasverraes
43 stars 25 forks source link

Preparing for Joomla 3.0 #17

Closed Bakual closed 12 years ago

Bakual commented 12 years ago

Hi Mathias

I have 4 commits for you to make JDump working in Joomla 3.0

2 change the JController, JModel and JView to their new Legacy versions. This raises the minimum requirements to Joomla 2.5.5 as those classes were introduced then.

1 is to replace the depreceated constant DS with "/".

1 is to remove some strict warnings

Bakual commented 12 years ago

By the way: Joomla 3.0 alpha has currently a bug which prevents raw format from working. I've opened a PullRequest over there: https://github.com/joomla/joomla-cms/pull/283.

mathiasverraes commented 12 years ago

2 change the JController, JModel and JView to their new Legacy versions. This raises the minimum requirements to Joomla 2.5.5 as those classes were introduced then.

I'm not too sure about this. We'd be reducing compatibility with existing version in favor of an alpha release. So I'd rather keep the classes as they are, and make a j3.0-compat release when there is an RC. Thoughts?

The more sensible solution would be for Joomla to leave the existing classes as is, and to pick a new name (or namespace) for the new classes.

Bakual commented 12 years ago

Hi Mathias

I agree with you that Joomla shouldn't have renamed existing classes. That would have made it much easier for extension developer. But they have their own ideas :-) At least they already introduced the new classes which are aliases to the old ones. So it's possible to create extensions that work in both versions.

The compatibility is reduced indeed, but on the other hand support for Joomla 1.5, 1.6 and 1.7 is cancelled and people should use Joomla 2.5.6 for their sites. The question is if extensions should still support Joomla releases which are no longer supported. One can have different opinions here.

I for myself decided to reduce backward compatibility in my extensions in favor for forward compatibility. People that have outdated Joomla versions can still download and use the outdated versions of my extensions. After all they seem to like outdated stuff :-)

You have to decide for yourself what you do with JDump. You can also just include the PullRequest when the RC is available. I did the changes so I could test my extensions with Joomla 3.0 alpha, so I'm fine anyway :-)

Greetings Thomas

-----Ursprüngliche Nachricht----- From: Mathias Verraes Sent: Thursday, July 19, 2012 10:47 PM To: Thomas Hunziker Subject: Re: [jdump] Preparing for Joomla 3.0 (#17)

2 change the JController, JModel and JView to their new Legacy versions. This raises the minimum requirements to Joomla 2.5.5 as those classes were introduced then.

I'm not too sure about this. We'd be reducing compatibility with existing version in favor of an alpha release. So I'd rather keep the classes as they are, and make a j3.0-compat release when there is an RC. Thoughts?

The more sensible solution would be for Joomla to leave the existing classes as is, and to pick a new name (or namespace) for the new classes.


Reply to this email directly or view it on GitHub: https://github.com/mathiasverraes/jdump/pull/17#issuecomment-7114819

miljan-aleksic commented 12 years ago

Hi,

Joomla 3 compatibility is now getting very needed :)

I liked Nicholas (Akeeba) approach for the legacy class, adapted to JDump would be something like this:

if(!class_exists('DumpWorksAroundJoomlaToGetAController')) {
    if(interface_exists('JController')) {
        abstract class DumpWorksAroundJoomlaToGetAController extends JControllerLegacy {}
    } else {
        class DumpWorksAroundJoomlaToGetAController extends JController{}
    }
}

class DumpController extends DumpWorksAroundJoomlaToGetAController {...}

And so on for JModel, etc. Nice and simple, I hope we can soon see the j3.0 compatibility :)

Thanks for the this great tool!

Bakual commented 12 years ago

You could use my fork. I use it in my testing enviroment. Just download and copy to your server with FTP and do a discover then. "Gruz" was also kind enough to make a installable file and offers it for download on his site: http://gruz.org.ua/en/about-joomla/29-joomla-extensions/10-jdump-for-joomla-30.html

miljan-aleksic commented 12 years ago

Unfortunatly I have fixed it on my own before seeing any of the forks... but is much appreciated :)

mathiasverraes commented 12 years ago

I've merged changes from this PR and the other one together in https://github.com/mathiasverraes/jdump/pull/19

I'd like to release that version ASAP, so if you guys could have a quick look and see if it works for you, that'd be super :-)

Closing this one.