I have been looking at the targets today and I have the feeling that some refactoring could be done here easily. I suggest the following things:
Improve indentation and white spacing: check target/A.inc in my branch to see what I have in mind
Improve comment indentation: So that they are all in one line - easier to parse with the eyes IMHO
Code de-duplication: There is a lot of duplicate code in the targets - I would suggest moving this code in common includes as I did with the LED and RPM macros - you know because "Don't repeat yourself"
I am fully aware that coding style is totally subjective and I have no hard feelings if this gets rejected. But since we are not trying to put the source code on a diskette, I am all for improving readability - a couple of blank lines do help a lot ;-)
I would build all the hex files pre refactoring and binary compare them after re-factoring to make sure the styling changes did not break anything else.
I have been looking at the targets today and I have the feeling that some refactoring could be done here easily. I suggest the following things:
target/A.inc
in my branch to see what I have in mindI am fully aware that coding style is totally subjective and I have no hard feelings if this gets rejected. But since we are not trying to put the source code on a diskette, I am all for improving readability - a couple of blank lines do help a lot ;-)
I would build all the hex files pre refactoring and binary compare them after re-factoring to make sure the styling changes did not break anything else.
https://github.com/stylesuxx/bluejay/tree/formatting