search

mathiasvr / youtube-terminal

:tv: Stream YouTube videos as ascii art in the terminal!
MIT License
107 stars 9 forks source link

Searching may cause errors #4

Closed mathiasvr closed 8 years ago

mathiasvr commented 8 years ago

The search result may produce unplayable results, such as this from an ad:

/usr/local/lib/node_modules/youtube-terminal/node_modules/ytdl-core/lib/util.js:222
    throw new Error('No video id found: ' + link);
    ^

Error: No video id found: https://youtube.comhttps://googleads.g.doubleclick.net/aclk?sa=L&ai=CyCBYAOltV7vAAdW8bpDMo6AD4YX9hkW6nbnJvwGuAhABIOP7kwNg0YGAgIQIyAEBqQLw5JtKqQKEPqgDAaoEkwFP0EPqWjJvNWGLoj1BCeNvDl_fsax4l4w17G25xzob2TwUnDf6SuIOjNQMPLfE-aIyB0eOgqjEKMYj4NZ5jvNRcYmdCox0XeUPooMTjAUTPyfEOPsemNDRrH8c-Bfcj4xgkY2Ra567V5v8vJS06FaPjMXmO6cMAm4i3AgOKPUBmRHxcChJcCfudYVwbGPfjLJNzNKgBhrIBuqn0PG_AYAHkoLVJqgHpr4b2AcBuBPoAQ&num=1&sig=AOD64_2y2ScZirALwgKbaIBCvW7R3impqw&ctype=21&video_id=bKJAezJDTyU&client=ca-pub-6219811747049371&adurl=http://www.youtube.com/channel/UC-TdJgDLvKMaNJiqg7Gs6oQ%3Fv%3DbKJAezJDTyU
    at Object.exports.getVideoID (/usr/local/lib/node_modules/youtube-terminal/node_modules/ytdl-core/lib/util.js:222:11)
    at Function.getInfo (/usr/local/lib/node_modules/youtube-terminal/node_modules/ytdl-core/lib/info.js:39:17)
    at play (/usr/local/lib/node_modules/youtube-terminal/index.js:33:8)
    at /usr/local/lib/node_modules/youtube-terminal/index.js:26:5
    at IncomingMessage.<anonymous> (/usr/local/lib/node_modules/youtube-terminal/node_modules/youtube-crawler/index.js:27:9)
    at emitNone (events.js:91:20)
    at IncomingMessage.emit (events.js:185:7)
mathiasvr commented 8 years ago

Fixed in https://github.com/96AA48/node-youtube-crawler/pull/1. Released as v0.4.3.