search

mathieuanthoine / PixiGAFPlayer

GAF Player for PixiJS
MIT License
23 stars 4 forks source link

Performance Optimisation #7

Open Shaylin opened 7 years ago

Shaylin commented 7 years ago

Hello,

Are there any plans to improve the peformance of the PIXIGAFPlayer?

I ask this because I have the same animation in both GAF and Spine yet I seem to be getting consistently worse performance with GAF ( . My testing involved creating multiple instances of the same animation on screen.

In order to make sure the problem wasn't the GAF animations I was using, I also tested using 5 instances of the "first_test" demo animations in this repo. My mobile device had a hard time keeping a consistent 60fps in this test yet the device could consistently maintain 60fps in more complex spine animations.

Thanks

mathieuanthoine commented 7 years ago

Hi @Shaylin ,

I have plans to optimize the PxiGAFPlayer but no time at the moment, I have no idea when I will work on it. Do you think it's possible to send me the different files you use for your tests in Spine and GAF ?

Thank you

Shaylin commented 7 years ago

Hi,

Unfortunately I can't send you the animations as they're company IP.

I did also test the first_test animation in this repo. It just seemed like 5 animations on screen shouldn't have had such a significant performance impact.

Would you be open to accepting a pull request with performance optimisation changes for PIXI GAF Player ? I might work on it in the future.

Thanks

mathieuanthoine commented 7 years ago

Absolutely!!! Any help is welcome :)

I'm not sure of the impact in performance bit one of the first step in optimization I would like to do is to remove useless getter/setters and replace these by properties. At this step, the code is a simple conversion of AS3 player.