When using TemplateProcessor for serveStatic pages do not respond "304 Not Modified"

[mawi42]

When template processor is used do not return "not modifed 304" but refresh the webpage. Template processors might be used for non static pages since some variables which will be replaced might change.

Proposed workaround instead of introducing new method serveDynamic, use info if templat processor is set (_callback).

Webhandlers.cpp line 218:

if (!_callback && _last_modified.length() && _last_modified == request->header(T_IMS)) {
      request->_tempFile.close();
      request->send(304); // Not modified
    } else if(!_callback && _cache_control.length() && request->hasHeader(T_INM) && request->header(T_INM).equals(etag)) {

[mathieucarbou]

Hello,

Your proposal cannot be implemented like you suggest, otherwise this is a behaviour change for any person who are using the callback mechanism and still have content that can be cached.

Could you please elaborate a big more on your use can with a code sample instead of suggesting a fix which breaks existing behaviour ?

AsyncStaticWebHandler is a subclass specifically designed to serve static content that can be cached.

If this is not what you want, then, don't use it...

Thanks :-)