mathieucarbou / ESPAsyncWebServer

Asynchronous HTTP and WebSocket Server Library for ESP32, ESP8266 and RP2040
https://oss.carbou.me/ESPAsyncWebServer/
GNU Lesser General Public License v3.0
51 stars 12 forks source link

[Feat] SSE client cleanup with DEFAULT_MAX_SSE_CLIENTS #58

Open notixor opened 1 month ago

notixor commented 1 month ago

DEFAULT_MAX_SSE_CLIENTS in AsyncEventSource.h not used anywhere

mathieucarbou commented 1 month ago

You're totally right: this fork is based on:

DEFAULT_MAX_SSE_CLIENTS was added by ESPHome guys, and looking at it, even now, they just added it but they do not use it.

I think they wanted to implement a cleanup procedure like it is done in the websocket part.

Feel free to contribute and add this feature! Like said, since I do not have any SSE use case at hand, if there's no contributions, this part will not be improved.

github-actions[bot] commented 2 weeks ago

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days.