search

mathieucarbou / license-maven-plugin

Manage license headers in your source files
https://oss.carbou.me/license-maven-plugin/
Apache License 2.0
240 stars 86 forks source link

"Detailed Maven documentation" not present #761

Closed mykelalvis closed 2 months ago

mykelalvis commented 2 months ago

Version affected

4.4

Describe the bug

No site generated documentation regarding goals, etc appears to be present. I assume the site docs are what is meant by "Detailed Maven documentation" but cannot be sure.

As an aside, changes from 4.3 (previous version) seem like non-semver breaking configuration changes, but I could be wrong about that because I don't know what those configs are, at present.

How to Reproduce

  1. Go to https://oss.carbou.me/license-maven-plugin
  2. Search for "Detailed Maven documentat"
  3. Click link
  4. Go nowhere from there
mathieucarbou commented 2 months ago

Hello,

Do you mean that ?

Screenshot_20240510-223411

Please do not hesitate to propose a change through a PR to improve if you feel it should be improved.

Thanks.

hazendaz commented 2 months ago

@mathieucarbou I think if you drill deep enough the maven site pages portion are not showing up and getting 404s. At least that is what I saw but not sure if that was working before or not as not looked at in some time.

mathieucarbou commented 2 months ago

Oh that's right ! I have 404 errors too. Weird because I generated the site and uploaded it.

I will anyway remove the ref to 4.4 and replace it by 4.5 this weekend after the new release.

Thanks for pointing that out!

mathieucarbou commented 2 months ago

fixed!