Correctly open URLs for reading

mathieucarbou / license-maven-plugin

Manage license headers in your source files

https://oss.carbou.me/license-maven-plugin/

Apache License 2.0

240 stars 86 forks source link

Closed pschichtel closed 2 months ago

pschichtel commented 2 months ago

fixes #760

scordio commented 2 months ago

Would it be possible to add an integration test to prevent future regressions? A test that uses one of the bundled licenses might be enough.

pschichtel commented 2 months ago

@scordio how about this quick test that the function can indeed read files from jar URLs?

mathieucarbou commented 2 months ago

I am out currently - I will be able to issue a new release this weekend with this fix. Thanks a lot for this PR 👍

scordio commented 2 months ago

@scordio how about this quick test that the function can indeed read files from jar URLs?

Looks good – thanks!