mathieudutour / github-tag-action

A Github Action to automatically bump and tag master, on merge, with the latest SemVer formatted version. Works on any platform.
https://github.com/marketplace/actions/github-tag
MIT License
625 stars 195 forks source link

pre_release_branches default to catchall #139

Open dctelus opened 2 years ago

dctelus commented 2 years ago

The option pre_release_branches defaults to `, but you are using.match` which always returns true when passed an empty string.

branch = "anything";
Boolean(branch.match('')) # always true

https://github.com/mathieudutour/github-tag-action/blob/v6.0/src/action.ts#L58

We use this behavior but it is not intuitive (maybe documentation should be updated to say that all branches are prerelease).