search

mathieudutour / github-tag-action

A Github Action to automatically bump and tag master, on merge, with the latest SemVer formatted version. Works on any platform.
https://github.com/marketplace/actions/github-tag
MIT License
641 stars 201 forks source link

getValidTags() should exclude tags that do not match the prefixRegex #158

Closed duality72 closed 1 year ago

duality72 commented 1 year ago

A fix for this issue: https://github.com/mathieudutour/github-tag-action/issues/143

This does introduce a slight behavior change in that tags that probably should have been excluded before are now definitely excluded. I think this is the correct behavior and people shouldn't have been relying on the previous behavior where tags without the requested prefix were being considered valid tags, but it is a change.

yelsayed commented 1 year ago

@mathieudutour, thanks for all your work. Would it be possible to make a new release with this fix. It's causing a small issue in our CI.