mathieudutour / github-tag-action

A Github Action to automatically bump and tag master, on merge, with the latest SemVer formatted version. Works on any platform.
https://github.com/marketplace/actions/github-tag
MIT License
641 stars 201 forks source link

"perf: commit" does not get identified as a Major release but a Patch version #159

Closed kalanatd closed 1 year ago

kalanatd commented 1 year ago

Hi all,

I am using this action to create releases in one of my workflows. The issue I am facing is even I am adding the commit message as "perf: commit change", the Action does not catch it and acts as a patch release instead of a major release. Other release types are getting tagged as expected. Am I doing something obviously incorrect? Any help would be really appreciated.

        uses: mathieudutour/github-tag-action@v6.0
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          default_bump: false
          tag_prefix: ''
          append_to_pre_release_tag: ''
          release_branches: release 

A few outputs I am getting for different commit messages.

  1. Commit message - "fix: release commit with fix - merge message" Output:

    The release type for the commit is patch

Result is Expected

Run mathieudutour/github-tag-action@v6.0
  with:
    github_token: ***
    default_bump: false
    release_branches: release
    default_prerelease_bump: prerelease
    create_annotated_tag: false
    fetch_all_tags: false
    dry_run: false
Previous tag was 1.0.0, previous version was 1.0.0.

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Analyzing commit: fix: release commit with fix - merge message
fix: release commit with fix - merge message
The release type for the commit is patch

Analysis of [21](https://github.com/dashmote/dash-git-tag-checker/actions/runs/3747075151/jobs/6362957520#step:3:22) commits complete: patch release
  1. Commit message - "feat: 1.0.1 to 1.1.1" Output:

The release type for the commit is minor Analysis of 3 commits complete: minor release

Result is Expected

  1. Commit message - "perf: 1.1.0 to 2.0.0" Output:

    Analyzing commit: perf: 1.1.0 to 2.0.0 perf: 1.1.0 to 2.0.0 The release type for the commit is patch Analysis of 3 commits complete: patch release

Result is not expected

Run mathieudutour/github-tag-action@v6.0
  with:
    github_token: ***
    default_bump: false
    release_branches: release
    default_prerelease_bump: prerelease
    create_annotated_tag: false
    fetch_all_tags: false
    dry_run: false
Previous tag was 1.1.0, previous version was 1.1.0.

Warning: The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/[2](https://github.com/dashmote/dash-git-tag-checker/actions/runs/3748232411/jobs/6365337912#step:3:2)022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Analyzing commit: perf: 1.1.0 to 2.0.0
The release type for the commit is patch
Analyzing commit: perf: 1.1.0 to 2.0.0

perf: 1.1.0 to 2.0.0
The release type for the commit is patch
Analysis of [3](https://github.com/dashmote/dash-git-tag-checker/actions/runs/3748232411/jobs/6365337912#step:3:3) commits complete: patch release
mathieudutour commented 1 year ago

why would a performance improvement require a major bump? If you want a major bump you need to have a breaking change in the body of the commit