mathieudutour / github-tag-action

A Github Action to automatically bump and tag master, on merge, with the latest SemVer formatted version. Works on any platform.
https://github.com/marketplace/actions/github-tag
MIT License
624 stars 195 forks source link

Bug: default_bump not respected + unwanted text added to tag #174

Open flymg opened 1 year ago

flymg commented 1 year ago

This action does not seem to work correctly.

      - id: tag_version
        name: Tag
        uses: mathieudutour/github-tag-action@v6.1
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          default_bump: "major" # also tried, major, minor
          tag_prefix: ""

Using this in a normal action with the latest tag available in my repo = 1.54.0 results in creating a new_tag by this action:

1.54.1-workflow.0

which is not correct, as the expected result should be 2.0.0

  1. Major version is not incremented, the option is not respected
  2. a Post text is applied: `-workflow.0``

EDIT: v5.5 does it correctly, though it also attaches the anoying -workflow.0 at the end of the tag

lazyBisa commented 1 year ago

The -workflow.0 indicates that he created a prerelease version. Although from your action, I cannot see why. Maybe you need to configure the release_branch? or default_prerelease_bump

flymg commented 1 year ago

@lazyBisa have you seen the other issue with the 2.0.0, that was not present in v5.5?

lazyBisa commented 1 year ago

which one?

flymg commented 1 year ago

@lazyBisa Steps to reproduce with the latest version of the action:

V.5.5 of the action makes the incrementation correctly.

lazyBisa commented 1 year ago

you mean the prerelease version applies the default bump? so 1.2.3 turns into 2.0.0-pre.0? I have an issue and PR open to fix that in 6.x

guiworks commented 1 week ago

The -workflow.0 indicates that he created a prerelease version. Although from your action, I cannot see why. Maybe you need to configure the release_branch? or default_prerelease_bump

You saved me, thanks