search

mathieuprog / polymorphic_embed

Polymorphic embeds in Ecto
Apache License 2.0
335 stars 62 forks source link

Fix: regard type field config when setting hidden fields #68

Closed woylie closed 6 months ago

woylie commented 2 years ago

resolves #67

Branched out from #66, since I'm using the new fields on the reminder module.

woylie commented 2 years ago

I'm not sure whether it's possible to find the name of the type field with the arguments passed to to_form/5. If it's not possible, we'd have to pass the schema as an additional argument, which would be a breaking change.

woylie commented 1 year ago

@mathieuprog I rebased this branch as well. I'm pretty busy with other stuff at the moment, so I'm not sure whether I can get to fixing this myself. If you have time, feel free to take over.

woylie commented 1 year ago

@mathieuprog I rebased this branch as well. I'm pretty busy with other stuff at the moment, so I'm not sure whether I can get to fixing this myself. If you have time, feel free to take over.

This PR is finished and includes the fix. Should be good to go.