mathigon / textbooks

Source code of Mathigon's interactive textbooks
https://mathigon.org
357 stars 154 forks source link

Typo in Triangles section of textbook #445

Open nigel-f-wilson opened 2 years ago

nigel-f-wilson commented 2 years ago

There is a paragraph that reads "You could also try using similar triangles, like we did in the previous course. This method requires knowing the distance to the base of the mountain: the point at sea level that directly below its summit." The final phrase should read "the point at sea level that lies directly below its summit."

nigel-f-wilson commented 2 years ago

I found the relevant content.md file and added in the missing word. I'll create a pull request based on that because I know the change I made won't have any unforeseen side effects. That said, I'd love to contribute more to Mathigon and I'm having a bit of trouble running the textbook program locally. After running npm install and then npm start I got the following error output. I'm wondering if I skipped a step on the setup or installation process?

> @mathigon/textbooks@0.7.3 start C:\Users\Nigel\Documents\GitHub\textbooks
> npm-run-all --parallel watch server

> @mathigon/textbooks@0.7.3 watch C:\Users\Nigel\Documents\GitHub\textbooks
> mgon-build --assets --watch --locales en

> @mathigon/textbooks@0.7.3 server C:\Users\Nigel\Documents\GitHub\textbooks
> mgon-serve

'"-S"' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 9009
npm ERR! @mathigon/textbooks@0.7.3 server: `mgon-serve`
npm ERR! Exit status 9009
polygonart6777 commented 2 years ago

Which version of Node do you have installed? You can check by using the command npm -v.

nigel-f-wilson commented 2 years ago

@polygonart6777 I'm running Node 16.13.1 and npm 8.13.1

aileenchoi commented 1 year ago

Hi! Has this issue been resolved?

Loren1999 commented 1 year ago

I had the same problem. node version: 16.18.1 npm version: 8.19.2 OS: Win10 64bit

Loren1999 commented 1 year ago

我找到了相关的 content.md 文件并添加了缺少的单词。我将基于此创建一个拉取请求,因为我知道我所做的更改不会产生任何不可预见的副作用。也就是说,我很乐意为 Mathigon 做出更多贡献,但我在本地运行教科书程序时遇到了一些麻烦。运行npm install后,npm start我得到以下错误输出。我想知道我是否跳过了设置或安装过程中的一个步骤?

> @mathigon/textbooks@0.7.3 start C:\Users\Nigel\Documents\GitHub\textbooks
> npm-run-all --parallel watch server

> @mathigon/textbooks@0.7.3 watch C:\Users\Nigel\Documents\GitHub\textbooks
> mgon-build --assets --watch --locales en

> @mathigon/textbooks@0.7.3 server C:\Users\Nigel\Documents\GitHub\textbooks
> mgon-serve

'"-S"' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 9009
npm ERR! @mathigon/textbooks@0.7.3 server: `mgon-serve`
npm ERR! Exit status 9009

The same problem exists in Linux system,But Normal operation under Mac OS....

Loren1999 commented 1 year ago

我找到了相关的 content.md 文件并添加了缺少的单词。我将基于此创建一个拉取请求,因为我知道我所做的更改不会产生任何不可预见的副作用。也就是说,我很乐意为 Mathigon 做出更多贡献,但我在本地运行教科书程序时遇到了一些麻烦。运行npm install后,npm start我得到以下错误输出。我想知道我是否跳过了设置或安装过程中的一个步骤?

> @mathigon/textbooks@0.7.3 start C:\Users\Nigel\Documents\GitHub\textbooks
> npm-run-all --parallel watch server

> @mathigon/textbooks@0.7.3 watch C:\Users\Nigel\Documents\GitHub\textbooks
> mgon-build --assets --watch --locales en

> @mathigon/textbooks@0.7.3 server C:\Users\Nigel\Documents\GitHub\textbooks
> mgon-serve

'"-S"' is not recognized as an internal or external command,
operable program or batch file.
npm ERR! code ELIFECYCLE
npm ERR! errno 9009
npm ERR! @mathigon/textbooks@0.7.3 server: `mgon-serve`
npm ERR! Exit status 9009

Mac上允许通过shebang传递CLI参数,但Linux不允许。 Linux系统需要将/node_modules/.bin/mgon-serve文件中第一行修改为#!/usr/bin/env ts-node-script

image

Windows系统下需要将/node_modules/.bin/mgon-serve.cmd进行如下改造 image I hope it will help you.

Loren1999 commented 1 year ago

你好!这个问题已经解决了吗?

You can try this method. See my reply on this page for details. I hope it will help you