search

mathisonian / d3moji

First class emoji support for D3
MIT License
127 stars 6 forks source link

font-awesome svg #2

Open timelyportfolio opened 9 years ago

timelyportfolio commented 9 years ago

I discovered this a couple weeks ago https://github.com/encharm/Font-Awesome-SVG-PNG, but unfortunately still does not solve the problem, since currently it seems you need something like the twemoji cdn to serve it up. It would be slow, but could just do a gh-pages branch of that repo to serve up the generated SVG.

mathisonian commented 9 years ago

Oh cool!

I wonder if we could use https://rawgit.com/ for this?

timelyportfolio commented 9 years ago

rawgit, especially the cdn version, would be an option (see FAQ), but I think the gh-pages route would work better. Want me to check with the author to see if he would like to do it? If not, it is simple enough to fork and add a branch. Still none of this would be a production solution. I wonder if it would be good to add a config option to specify a url for the svg.

mathisonian commented 9 years ago

Yeah, that sounds good if you don't mind reaching out to them.

+1 for having a config for the URL, I was planning on adding that at some point anyways.

timelyportfolio commented 9 years ago

since @encharm so nicely added a gh-pages branch, the url pattern will be

http://encharm.github.io/Font-Awesome-SVG-PNG/svg/*.svg

I'm thinking we will need to transform this to limit the viewBox.