search

mathjax / MathJax-i18n

MathJax localization
Apache License 2.0
16 stars 10 forks source link

Added Vietnamese to config.js #1

Closed 1ec5 closed 10 years ago

pkra commented 10 years ago

Thanks for the pull request. This looks ok to me.

@siebrand could you weigh in? It seems to me that, in general, code changes here on github will not be reflected on TranslateWiki.net -- which could be a problem. But in this case it's config.js which (I think) does not get updated via TranslateWiki.net anyway. Is that correct?

siebrand commented 10 years ago

@pkra Correct, Peter. From translatewiki.net, we do not touch config.js. This may also mean that languages are available in the source code that have not been enabled. Who's the i18n responsible for that at MathJax?

pkra commented 10 years ago

@siebrand

From translatewiki.net, we do not touch config.js.

Thanks for confirming.

This may also mean that languages are available in the source code that have not been enabled.

That's correct.

Who's the i18n responsible for that at MathJax?

Myself or @dpvc will take care of these in the future. Won't be hard to update the file for the next release. I've created https://github.com/mathjax/MathJax/issues/753 to track this.

pkra commented 10 years ago

@siebrand would you be able to confirm that this pull request meets TWN's standards?

siebrand commented 10 years ago

@pkra There's no twn standard here, AFAIK. If this is what is needed to enable Vietnamese in MathJax, that should be fine.

pkra commented 10 years ago

I think I put that too confusingly.

This kind of pull request does slightly more than enabling the Vietnamese locale; it also contains localization information (string for the menu entry, description of plural forms and decimal separator). IIUC, this pull request is correctly configuring the Vietnamese locale.

I was hoping for a second opinion regarding those specifics. But I'm ok with merging it either way.

siebrand commented 10 years ago

@pkra Checking all the possible i18n properties for number formatting would be a drag. I assume the patch submitter actually know what they are doing (right? :P). Ideally, MathJax would use something like https://github.com/rxaviers/cldr

pkra commented 10 years ago

Thanks for the comment @siebrand . We'll look into cldr.

@dpvc alright to merge?

pkra commented 10 years ago

Thanks for the additional comments, @1ec5 !