search

mathjax / MathJax-node

MathJax for Node
Apache License 2.0
615 stars 97 forks source link

fix speakText + original alttext leading to duplication in output #237

Closed pkra closed 8 years ago

pkra commented 8 years ago

Fixes #236

pkra commented 8 years ago

@zorkow travis fails because of the SRE test. Could you look into it?

pkra commented 8 years ago

Thanks, @dpvc. I've updated the PR.

dpvc commented 8 years ago

I'm not sure a decision was made about whether alttext should override speech text or vice versa. I prefer keeping the alttext if there is one, but your comment about #207 makes sense, so I'm OK with this for now and will merge it once you have a chance to react to the comments I just left.

pkra commented 8 years ago

I'm not sure a decision was made about whether alttext should override speech text or vice versa. I prefer keeping the alttext if there is one, but your comment about #207 makes sense, so I'm OK with this for now and will merge it once you have a chance to react to the comments I just left.

I thought I had brought it up at a F2F but I'm ok with switching. We can discuss it at the next F2F, too.

dpvc commented 8 years ago

I thought I had brought it up at a F2F but I'm ok with switching. We can discuss it at the next F2F, too.

I don't recall, but perhaps it is one that I missed. We can discuss it tomorrow if you want. As I said, it is not critical either way, as the speech generation is going be removed anyway.

pkra commented 8 years ago

I've updated the PR.

pkra commented 8 years ago

Hopefully without any more silly errors from my side. Sorry about that.