search

mathjax / MathJax-node

MathJax for Node
Apache License 2.0
615 stars 97 forks source link

state.ID does not increment #260

Closed pkra closed 8 years ago

pkra commented 8 years ago

This is because the state is update in TypesetDone before GetSVG runs (to increment it).

Relates to #207.

pkra commented 8 years ago

Simple fix is to change state in GetSVG but again #207.

dpvc commented 8 years ago

The problem was caused by commit 95644e79 that broke TypesetDone() into two parts, and moved the TypesetDone() call to before the rest of the routines (including GetSVG()). I think the solution is to move the saving of the state to the final routine, ReturnResult(), like it was originally so that it is done after the increments. Saving the state can certainly be considered part of returning the result, after all.

pkra commented 8 years ago

Copy that. Will probably have time when I'm back from TPAC.