search

mathjax / MathJax-node

MathJax for Node
Apache License 2.0
615 stars 97 forks source link

[main] enable css output without html output #296

Closed pkra closed 7 years ago

pkra commented 7 years ago

Resolves #292

dpvc commented 7 years ago

I think the test should also check if the svg element is produced (one of the two changes relates to that). I would also say that the tests should also check if only the desired properties are produced. For example speakText appears in the result whether you have asked for it or not.

dpvc commented 7 years ago

Other than that, the PR is good.

pkra commented 7 years ago

Thanks! I'll update the test.

pkra commented 7 years ago

I would also say that the tests should also check if only the desired properties are produced.

That will be covered by #285, correct?

dpvc commented 7 years ago

That will be covered by #285, correct?

It would be if that were implemented, yes. But no one commented on it, so I was not sure if anyone thought that was a good idea.

pkra commented 7 years ago

But no one commented on it

Copy that. Just added +1.

Also, I've updated the test. PTAL?

dpvc commented 7 years ago

OK, looks good.