search

mathjax / MathJax-node

MathJax for Node
Apache License 2.0
616 stars 97 forks source link

improve full-width characters rendering #358

Closed ambar closed 7 years ago

pkra commented 7 years ago

Thanks for the PR.

Please note that PRs must be based on the develop branch (not master).

You also might want to add some comments on what you are trying to do. (I'm guessing this is for #299?)

ambar commented 7 years ago

@pkra rebased!

ambar commented 7 years ago

I tried to use Puppeteer(https://github.com/ambar/puptex) before I found this workaround, do you think it's worth?

pkra commented 7 years ago

@ambar a fix for #299 would be great (and should have better overall performance than spinning up puppeteer/Chrome). But @dpvc will have to comment on the approach you're taking.

ambar commented 7 years ago

@pkra Thanks!

dpvc commented 7 years ago

@pkra, I'm OK with the change, if you want to merge it.

pkra commented 7 years ago

Thanks. I just have not got around to it -- the pending bug fix release needs to be wrapped up before we merge.

pkra commented 7 years ago

Sorry for taking so long to come back to this.

We're ok with merging as is.

(We thought about adding an option to customize widths of halfwidth forms but that can be done later.)

pkra commented 7 years ago

I'm wondering if we should generalize this using https://github.com/sindresorhus/string-width. I'll make a new issue.