search

mathjax / MathJax-node

MathJax for Node
Apache License 2.0
615 stars 97 forks source link

[main] add option for custom path variables #391

Closed pkra closed 6 years ago

pkra commented 6 years ago
pkra commented 6 years ago

This should wait until the next feature release.

pkra commented 6 years ago

Also, this is only meant as a first draft.

pkra commented 6 years ago

I have no idea why the URL test fails on old node versions. I'll look into it.

dpvc commented 6 years ago

Looks like a reasonable approach.

pkra commented 6 years ago

I believe the failing tests are independent of this issue.

They seem to be due to MathJax v2.7.3 being installed on old versions of npm which do not support the package lock file (and thus do not stick to 2.7.2).

@dpvc @zorkow is it ok to update the package lock file to MathJax v2.7.3?

pkra commented 6 years ago

@zorkow ok'ed this F2F. I'll update the PR.

pkra commented 6 years ago

I've also fixed a typo in the Readme.

dpvc commented 6 years ago

Your earlier comment indicated this was a first draft. Are you ready for merging at this point?

pkra commented 6 years ago

Your earlier comment indicated this was a first draft. Are you ready for merging at this point?

I'm ready. I just wasn't sure if that approach is acceptable.