search

mathjax / MathJax-node

MathJax for Node
Apache License 2.0
614 stars 96 forks source link

[WIP] PreviewHTML support #403

Closed pkra closed 5 years ago

pkra commented 6 years ago

A first proposal towards #163.

Looking for feedback.

pkra commented 6 years ago

I've added a commit to extend the renderer variable so it handles PreviewHTML.

pkra commented 6 years ago

I've rebased and all tests pass now.

@dpvc could you take a quick look and tell me if this approach is generally ok with you? (I had a quick chat with @zorkow who suggested your review).

Then I could start to write a few basic tests.

dpvc commented 6 years ago

It seems to be doing the right thing. I haven't looked through the PreviewHTML code to see what else would need to be overriden, but the framework seems to be OK.

I'm not sure what the use case is, however. The preview HTML results are not very good, and it is not feature complete. In general, it is not output that I would like to see being used in production work as the final layout.

pkra commented 6 years ago

Thanks, @dpvc.

I've come to appreciate the output again recently and want to see how far I can go with it. But I'll need mathjax-node integration to really test things.

pkra commented 6 years ago

@dpvc ping - if you have some time.

pkra commented 5 years ago

Thanks. As discussed F2F, this won't be accepted.