search

mathjax / MathJax-src

MathJax source code for version 3 and beyond
https://www.mathjax.org/
Apache License 2.0
2.05k stars 205 forks source link

Fixes issues with firefox and safari. #1058

Closed zorkow closed 6 months ago

zorkow commented 7 months ago

These are the workarounds for the issues regarding voice events on Firefox. @dpvc can you have a look if this works for Safari as well?

dpvc commented 7 months ago

Here are the list of continuing issues from our chat today:

dpvc commented 7 months ago

I figured out the third issue above, and have fixed it in my menu update branch (not yet pushed).

zorkow commented 7 months ago

Here are the list of continuing issues from our chat today:

  • Hover highlighting leads to an error.

This was a CHTML error in SRE, which is now being caught (latest develop branch). But note that hover only works when the explorer is active. Otherwise we do not have a highlighter as those are only created when we have an ExplorerItem. We can probably change that in the future, but I am not sure if it is worth it.

  • While explorer is active, all key events are blocked (including reload, etc.)

That is now no longer the case.

  • Can't start explorer if both speech and braille are unchecked. I believe that this is due to the fact that there are no role attributes in that case, because those seem to be added during the speech/braille creationSpeech() function in semantic-enrich, which isn't being called.

That was actually an issue related to how explorers were attached. Previously, speech, braille and keyMagnifier would attach their own explorer, now only speech attaches the SpeechExplorer which handles all three duties. So we need to see if at least one of the three options in options.a11y is set, to attach and thus enable the SpeechExplorer.

  • After a change in language, you must do a move to get new language (but you know this one already).

We now have a similar issue with switching speech/braille before retypesettting. This is best fixed once the new Menu structure is integrated.

dpvc commented 7 months ago

That was actually an issue related to how explorers were attached.

I fixed it in the sre-menus branch, as I mentioned above, so you don't need to worry about that one.

zorkow commented 6 months ago

After a change in language, you must do a move to get new language (but you know this one already).

This is now fixed. However, we still have an issue when changing rule sets/preference settings. I will tackle this in a new PR to simplify review.

zorkow commented 6 months ago

@dpvc as discussed today, this should be ready to merge.