mathjazz / pontoon

In-place localization tool
https://pontoon.mozilla.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

[translate] Improve quality checks #1036

Open mathjazz opened 8 years ago

mathjazz commented 8 years ago

This issue was created automatically by a script.

Bug 1221552

Bug Reporter: @mathjazz CC: cgrebs@mozilla.com, felix.bau@gmx.de, mvasicek@mozilla.cz, @tomer, vsatayamas@gmail.com, willkg@mozilla.com, @yfdyh000 Depends on: Bug 1224273, Bug 1376728

Our quality checks have two issues:

1) There are a lot of false positives. 2) They only show warnings, which users can easily ignore.

Our current implementation uses POfilter tests: http://translate-toolkit.readthedocs.org/en/latest/commands/pofilter_tests.html

Many Mozilla sites use dennis to prevent bad translations from causing errors in production, so we should look into its API and use it: https://dennis.readthedocs.org/

We should split tests into different categories by importance (POfilter supports that), something like:

A) COSMETIC: These tests should be removed. B) WARNING: We show a warning, which can be ignored. C) ERROR: We prevent translation from being submitted. If detected on import, store it as suggestions.

mathjazz commented 8 years ago

Comment Author: Will Kahn-Greene [:willkg] ET needinfo? me <willkg@mozilla.com>

As a note, I maintain Dennis which makes it easier to fix Dennis to meet additional needs.

mathjazz commented 8 years ago

Comment Author: Vee Satayamas <vsatayamas@gmail.com>

I found 2-3 false positive errors per one Thai string. It would be nice if Quality Checks is disable by default for Thai since it may prevent people from contributing.

mathjazz commented 7 years ago

Comment Author: @mathjazz

Bug #1298852 has been marked as a duplicate of this bug.

mathjazz commented 7 years ago

Comment Author: @mathjazz

As pointed out by tomer in bug #1298852, we should also:

1) Allow team managers to turn specific checks on and off for their locale/project. 2) Add additional checks like spell checking or something like languagetool.org.

mathjazz commented 7 years ago

Comment Author: @mathjazz

As pointed out by Michak in bug #1342568, we should also highlight the error in the translation, to help users identify their mistakes.

mathjazz commented 7 years ago

Comment Author: @mathjazz

Bug #1342568 has been marked as a duplicate of this bug.

mathjazz commented 6 years ago

Comment Author: @mathjazz

Bug #1446696 has been marked as a duplicate of this bug.

mathjazz commented 6 years ago

Comment Author: @mathjazz

Bug #1497337 has been marked as a duplicate of this bug.