search

mathjazz / pontoon

In-place localization tool
https://pontoon.mozilla.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Create portable Docker image #1165

Open mathjazz opened 5 years ago

mathjazz commented 5 years ago

This issue was created automatically by a script.

Bug 1513104

Bug Reporter: dane.molotok@gmail.com CC: @adngdb, @Pike, @eemeli, erickwilder@gmail.com, keunes@mailbox.org, @mathjazz, me@avm99963.com, mlzc@hey.com, santosh.prajapati@ibriz.ai

Pontoon is heavily tailored to be deployed on Heroku. With some massaging, the work done for the dev Docker container could be used to create a production-ready Docker image. This could be published on DockerHub and used by folks who want to run Pontoon in their existing infrastructure.

mathjazz commented 5 years ago

Comment Author: dane.molotok@gmail.com

I have this working on our Mesos cluster. I will pull request shortly.

mathjazz commented 5 years ago

Comment Author: @Pike

Created attachment 9085138 GitHub Pull Request [Closed]

Attached file: file_1513104.txt (text/x-github-pull-request, 44 bytes) Description: GitHub Pull Request [Closed]

mathjazz commented 4 years ago

Comment Author: erickwilder@gmail.com

The linked pull request was closed and I was wondering if there is any intention to resume the work on this topic. Do you need any help on that? I was planning to deploy Pontoon on a Kubernetes cluster but if we have an official docker image this would be much more beneficial to the whole community, not only a few people trying the same as I am.

mathjazz commented 4 years ago

Comment Author: @mathjazz

Hey erickwilder, we'd be more than happy to mentor you!

I'm leaving NI for :adrian (on PTO until Thursday), who's been actively involved in the work that has been done so far. He should be able to give you more concrete pointers.

mathjazz commented 4 years ago

Comment Author: @adngdb

Hey Erick,

We would be very glad to have your help on this. I tried to write our Pontoon Dockerfile so that it is as production-ready as possible. There are, however, a few things that need to be changed in order to make the current one actually fit for a production deployment.

What would be really great, if you could manage that, would be to make our main Dockerfile production-ready, while still being able to use it for local development with the docker-compose file on top of it. That probably means making it a multi-stage build, with the dev image having all tools used for building (as we need them regularly for development) and the prod one having as little as possible.

Anyway, please do feel free to work on this, and I'll be happy to help!

mathjazz commented 3 years ago

Comment Author: @Pike

As this has come up again, IMHO it's a lot more important to create a production-ready version of https://github.com/mozilla/pontoon/blob/master/docker/run_webapp.sh, akin to https://github.com/mozilla/pontoon/blob/master/Procfile#L1.

It's also an interesting question if the daemon should use the same image, or a different one?

And, in the context of something like kubernetes, where should ./manage.py migrate run?

mathjazz commented 3 years ago

Comment Author: Michael Lin <mlzc@hey.com>

(In reply to Axel Hecht from comment #6)

As this has come up again, IMHO it's a lot more important to create a production-ready version of https://github.com/mozilla/pontoon/blob/master/docker/run_webapp.sh, akin to https://github.com/mozilla/pontoon/blob/master/Procfile#L1.

It's also an interesting question if the daemon should use the same image, or a different one?

And, in the context of something like kubernetes, where should ./manage.py migrate run?

Coming from https://github.com/mozilla/pontoon/pull/1779.

We are running a production instance at https://translate.skills.network on K8S. It's designed in a way that no change is made to Pontoon source code and we can still run it in a really flexible way.

We take the Dockerfile from the Pontoon repo without modification and publish it to Docker Hub. Here's the process of building and pushing the image. https://github.com/ibm-skills-network/pontoon/blob/master/.github/workflows/push-image.yml I don't see why the current Dockerfile is not suitable for production deployment if we ignore the fact there are security vulnerabilities in packages and there are a bunch of dev dependencies that are not needed :). The point is, it has everything we need to get it working.

In the Helm Chart (a package manager for K8S), we try to replicate how Pontoon is run on Heroku (The Procfile). https://github.com/ibm-skills-network/charts/tree/master/charts/pontoon

  1. pontoon-deployment, the web process. NOTE, we don't use the default entrypoint but use gunicorn to run the production server.
  2. ponton-worker-deployment, the worker process.
  3. ponton-migration-job. It will be run whenever the chart is installed or updated.
  4. ponton-sync-projects-cronjob. cronjob that runs the sync_projects command periodically.

It also comes with some features that we think are helpful

mathjazz commented 3 years ago

Comment Author: santosh.prajapati@ibriz.ai

Hi Erick,

  1. Do you have any documents or steps to deploy in other cloud providers like AWS?
  2. What are the things that must be considered if we deploy pontoon in the production with docker-compose?

I really appreciate any help you can provide.

mathjazz commented 3 years ago

Comment Author: keunes@mailbox.org

Just to note that there's I too have an interest in this. I'm wondering what's necessary to get this done. There's interest in the result, there's people who are willing to work on it, others using a docker image in production already, and Mozilla seems to have indicated willingness to mentor those getting this ready.

Is there any way I can help to move this forward? I could help organise a quick call, for example (I'm not a developer and don't know much about docker).

mathjazz commented 3 years ago

Comment Author: @mathjazz

As mentioned on Discourse, this is one of the items that Mozilla doesn't directly benefit from, because it doesn't use it. Hence the P5.

We need someone to pull this forward, provide the patch and we'd be happy to provide feedback and review.

You are welcome to join us at the weekly call every Thursday at 1700 CET at https://mozilla.zoom.us/j/208705274, where we can discuss the next steps.

mathjazz commented 3 years ago

Comment Author: @eemeli

Mentioning here in case there are any interested parties: Some Pontoon Dockerfile progress is starting to happen with https://github.com/mozilla/pontoon/pull/1996, which might get followed by further changes leading to an improved experience for those looking to use Pontoon via a portable/prod-ready Docker image.

To be clear, this is a part of an effort to improve the developer experience and e.g. reduce unnecessary Docker image re-builds, rather than an effort to explicitly produce a prod-ready Docker image.