[FTL] Empty attribute not displayed in the UI

[mathjazz]

This issue was created automatically by a script.

Bug 1591416

Bug Reporter: @flodolo CC: @adngdb, @Pike, @mathjazz

https://pontoon.mozilla.org/translate/hy-AM/firefox/browser/browser/newtab/asrouter.ftl/?search=cfr-doorhanger-milestone-ok-button&string=204800

Committed to the repository: https://hg.mozilla.org/l10n-central/hy-AM/rev/e9eca9148f4ffdfc91703dacc3aa59bc2d333814#l4.84

And resulting in Junk

cfr-doorhanger-milestone-ok-button = Պահպանել բոլորը
    .accesskey = 

The accesskey attribute is not visible in the UI, unless you switch to the advanced FTL, where you'll see the empty accesskey. I think that's the main issue here, an empty attribute should show up.

[mathjazz]

Comment Author: @flodolo

Created attachment 9104214 Normal UI

Attached file: immagine.png (image/png, 42070 bytes) Description: Normal UI

[mathjazz]

Comment Author: @flodolo

Created attachment 9104215 FTL mode

Attached file: immagine.png (image/png, 45051 bytes) Description: FTL mode

[mathjazz]

Comment Author: @Pike

How does that even .... ?

cfr-doorhanger-milestone-ok-button = Պահպանել բոլորը
    .accesskey = 

is a parse error, and Pontoon should refuse to serialize that.

[mathjazz]

Comment Author: @flodolo

I'm trying on stage but I can't figure out how to do it, I get either "Expected value" or "Missing attribute .accesskey" https://mozilla-pontoon-staging.herokuapp.com/translate/hy-AM/firefox/all-resources/?status=missing&search=.accesskey&string=201249

Adrian, any change that might have fixed it? The translation was about a week old.

[mathjazz]

Comment Author: @flodolo

OK, found it: you need a TAB character in the accesskey 😱

1) COPY English translation 2) Switch to FTL view 3) Copy the text to a text editor, replace the accesskey with a TAB character 4) Paste back in Pontoon and save

I think we disabled the TAB character in the editor (or I can't find a way to add one), and that might explain why we can't reproduce it anymore. Still, it feels like we should do something else here.

[mathjazz]

Comment Author: @adngdb

It was possible to add a "tab" character back when we had the Ace editor for Fluent Source mode. However, the problematic translation was sent 2 weeks ago, and we definitely didn't have it anymore at that point. Something weird happened there.

So this is a tough spot. My initial reaction was: Fluent should remove the trailing tab character, and complain that the accesskey is empty. But isn't "Tab" an actual valid access key? In which case, I don't know where the bug is, but I think Pontoon should show an input there with a tab character in it, even though that would be very strange to the users as mostly invisible.