search

mathjazz / pontoon

In-place localization tool
https://pontoon.mozilla.org/
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

Brush up silme as used in Pontoon #1275

Open mathjazz opened 3 years ago

mathjazz commented 3 years ago

This issue was created automatically by a script.

Bug 1692430

Bug Reporter: @Pike CC: @julen, @mathjazz See also: https://bugzilla.mozilla.org/show_bug.cgi?id=1696486

Matjaz' fork of silme on https://github.com/mathjazz/silme has at least a deprecation warning issue.

But it's also not possible to run the tests on py3, so there's a bit of cleanup work to do.

Matjaz, what do you think, should we remove code not used by Pontoon to reduce the amount of code we need to maintain there? Thinking about unused formats in https://github.com/mathjazz/silme/tree/master/lib/silme/format, and IOs in https://github.com/mathjazz/silme/tree/master/lib/silme/io, for example.

mathjazz commented 3 years ago

Comment Author: @mathjazz

Can we replace silme with compare-locales in its current state?

If not, reducing the library to what we actually need sounds like a good idea. https://github.com/mathjazz/silme/tree/master/lib/silme/diff also looks like something we should consider removing.

mathjazz commented 3 years ago

Comment Author: @Pike

I don't think we can use c-l as is, I don't see anything doing encoding for DTDs, for example.

I'll go ahead and push silme around a bit.

mathjazz commented 3 years ago

Comment Author: @julen

(In reply to Matjaz Horvat [:mathjazz] from comment #1)

Can we replace silme with compare-locales in its current state?

If py3 and maintenance are the concerns, have you considered Translate Toolkit? It's already a Pontoon dependency, and it has supported DTD, inc, ini, properties for a while.

mathjazz commented 3 years ago

Comment Author: @Pike

Created attachment 9202890 GitHub Pull Request

Attached file: file_1692430.txt (text/x-github-pull-request, 40 bytes) Description: GitHub Pull Request

mathjazz commented 3 years ago

Comment Author: @Pike

Created attachment 9206478 mo'cleanup and black and flake8 and pyupgrade

Attached file: file_1692430.txt (text/x-github-pull-request, 40 bytes) Description: mo'cleanup and black and flake8 and pyupgrade

mathjazz commented 3 years ago

Comment Author: @Pike

The only think left here from my POV is to cut the 0.11 release. Matjaz, anything you'd like to do?

mathjazz commented 3 years ago

Comment Author: @mathjazz

I think that's it.

I've transferred the repo to https://github.com/mozilla/silme and Osmose "unforked" it. \o/