mathnet / mathnet-filtering

Math.NET Filtering (formerly Neodym)
http://filtering.mathdotnet.com
Other
235 stars 80 forks source link

Support Xamarin Android #6

Closed avinabmalla closed 7 years ago

avinabmalla commented 7 years ago

I was unable to add the NuGet package to a Xamarin Android project. It was strange, as I could add the numerics package but not this one. Mybe this project was created as a regular class library instead of a portable one.

2016-07-22

Thanks!

ghost commented 7 years ago

I have created a portable class library for mathnet-filtering that passed the current unit tests and works in my application. Would the mathnet team be interested in a pull request for this?

cdrnet commented 7 years ago

I'd certainly accept a PR to add support for a PCL build. To keep it maintainable it should follow the same style as the other Math.NET projects do (mostly Numerics) though, e.g. such that the release process is fully automated.

ghost commented 7 years ago

Would you prefer a separate PCL project to be added to the current solution, or that the PCL replaces the current project?

cdrnet commented 7 years ago

I think i the medium term we'd want to target both .Net Framework (pure; v4 or higher) and .Net Standard v2.0. Until the tooling around .Net Standard is ready, having two projects, one for .Net 4 and one for a PCL would make sense, and is also in line with the other Math.NET Projects (e.g. Numerics: PCL project files, .All solution including them, , build package, build variants, etc)

cdrnet commented 7 years ago

I'd propose to support only 1 PCL profile here, of course, not 5 different ones like Numerics. Profile 259 could be a good choice as it transfers nicely to .Net Standard.

ghost commented 7 years ago

Ok. So if I forked the master, added the PCL project to the solution and did a PR, would anything else need to change?

cdrnet commented 7 years ago

That would be fine - I can take care of the rest (mostly extending build.fsx). Thanks!

ghost commented 7 years ago

Ok. I'll get on it.

ghost commented 7 years ago

PR has been submitted

ghost commented 7 years ago

@cdrnet How the PR going? Anything I can do to help?

cdrnet commented 7 years ago

Math.NET Filtering - finally - supports the portable profile 259 (and .Net 3.5), since v0.3.0.

@tura08 thanks a lot for putting work into this and providing a pull request. Unfortunately I was not clear enough what I meant with adding a project (this is a learning for me - I meant just the project file, pointing to the same sources) and I could therefore not merge the pull request as it would have deviated from the Math.NET approach, which would make this project unmaintainable for me.

ghost commented 7 years ago

@cdrnet not a problem, glad to help. Out of curiosity, what did you adjust in the project file to get it to build as PCL? I can't see anything in the latest commit.

cdrnet commented 7 years ago

@tura08 ah, forgot to push. It is there now.