search

mathnet / mathnet-filtering

Math.NET Filtering (formerly Neodym)
http://filtering.mathdotnet.com
Other
235 stars 80 forks source link

.NET Standard support #9

Closed ghost closed 5 years ago

ghost commented 7 years ago

It would be great to have this library .net standard compatible. It can then be used with every runtime. What would need to be changed to get it to this point?

TobiasGlaubach commented 5 years ago

Hi, I just did some quick hacking to test a migrate of the project to NET Standard 2.0 and was able to compile and test the project successfully after a few minor adjustments. Therefore I would say, that the library from a technical point of view is fully compatible with NET Standard 2.0.

We would need to figure out a proper migration strategy though.

Here is my hacky test branch: https://github.com/TobiasGlaubach/mathnet-filtering/tree/net-core-migrate-test

Test results: grafik

TobiasGlaubach commented 5 years ago

@cdrnet The Mathnet.Numerics package is already available as NetStandard, can you give any advice on the strategy for adding NetStandard support for this project as well?

I am not very familiar with solution / project setup, or nuget package rollout for various frameworks, but shouldn't a complete migration to simple csproj based classlibs for NetStandard2.0 and deployment through the dotnet pack CLI support all kinds of previously supported Frameworks?

cdrnet commented 5 years ago

It's not so simple in practice since we also want to code sign both assemblies and packages, generate the website and api reference, a zip archive, etc. The easiest and also most convenient way for me is thus to simply reuse the infrastructure from Numerics. I've just done that in the commit above, which seems to produce valid packages for .Net Framework 4.0 and 4.6.1 and .Net Standard 1.3 and 2.0.

Before publishing I should have a closer look at #13 though, and maybe pull it in.

cdrnet commented 5 years ago

Thanks again. NuGet packages version v0.5.0 and newer support .Net Standard.