search

mathnet / mathnet-numerics

Math.NET Numerics
http://numerics.mathdotnet.com
MIT License
3.51k stars 898 forks source link

Added Differentiate3 to Interpolation #1093

Open osswaldo opened 2 months ago

jkalias commented 2 months ago

I would like to see some unit tests for this.

osswaldo commented 2 months ago

I tool a closer look into the tests and there aren't any tests for the Differentiate methods at all.

jkalias commented 2 months ago

Maybe we can start now having tests for it? ☺️ I don’t mean ALL the existing methods of course, just this new addition.

osswaldo commented 2 months ago

Ok, done ;)

jkalias commented 1 month ago

This is awesome, thank you

jkalias commented 1 month ago

It’s been more than 2 years that the latest 5.0 release of the library has been published. I’m not the official maintainer but I wouldn’t have something against releasing a 5.1 version with this change among others (it’s adding a feature, not removing existing ones or changing functionality)

osswaldo commented 1 month ago

It isn't a realy "breaking" change if one extend an interface. You can simply implement the method as not implemented. However, it could be make sence to introduce an IDifferentiableInterpolation in order to remove the SupportsDifferentiation property.