search

mathnet / mathnet-spatial

Math.NET Spatial
http://spatial.mathdotnet.com
MIT License
376 stars 132 forks source link

Update Numerics Reference to 4.0.0 #153

Closed Jones-Adam closed 6 years ago

Jones-Adam commented 6 years ago

Aligned build files to latest 'common' files from Mathnet.Numerics Fixed compile warnings Updated SDK and framework versions on Travis Switched back to using Paket Fix #129 - Linux build for mono is now working again "Build Benchmarks" now correctly copies the results into the source directory

Jones-Adam commented 6 years ago

@cdrnet I have also synced the changes you have made to Numerics post Beta06 (until this commit ) . If you have the time could you give me a brief description of the steps involved in preparing the signed version and in publishing so I can check those are working too? Thanks

cdrnet commented 6 years ago

Thanks a lot, this will make my life significantly easier in the near future!

The whole release process is fully automated, the only steps I usually need to do are:

However, currently the publishing part in the last command is assuming that only I do releases, and thus does not even try to be generic. If you would like to do releases of Spatial as well (which would be great), I need to rethink this a bit.

Regarding signing, I assume you refer to the optional "sign" argument, not strong naming. I have a personal certificate which I technically cannot share (key is on a smart card), nor want to. But signing is not required, that's why it is a separate argument to opt-in. If you happen to have a code signing certificate as well, we'd need to make the build script a bit more flexible to allow choosing the right certificate.

Regarding testing, maybe it is easiest for now if I simply smoke-test it myself.

Jones-Adam commented 6 years ago

Ok so based upon what you said - as far as I can tell "Build all" works and updates the csproj as expected, so feel free to merge this PR if you are happy to look after the sign/publish parts. (at least for now)

It currently builds as Spatial 0.5-Beta02, so you could reasonably run through the whole process including publishing to make sure it works. It would at the very least be interesting to see how many people would download a preview version of spatial with .netstandard support.

Jones-Adam commented 6 years ago

I updated this to the release version of Numerics 4.0.0.

JohanLarsson commented 6 years ago

Did you switch to paket magic mode? If yes paket.bootstrapper.exe should be removed. If no paket.exe should not be in the repo as it is downloaded by the bootstrapper.

Jones-Adam commented 6 years ago

Yes, Numerics switched to paket magic mode, so I did this also here and paket.bootstrapper.exe was removed in this PR.