search

mathnet / mathnet-spatial

Math.NET Spatial
http://spatial.mathdotnet.com
MIT License
376 stars 132 forks source link

Implemented IsParallelTo, IsPerpendicularTo, IsCollinearTo, IsCoplana… #228

Closed kabircosta closed 1 year ago

kabircosta commented 1 year ago

…rTo methods and Arc2D class. Tests are still pending.

jkalias commented 1 year ago

Thanks for your effort.

There is no Line2D and Line3D type anymore, just Line (a general 3D line). I am in a trajectory of eliminating all 2D/3D redundancies (according to #200 ) so the master branch is changing quite rapidly lately.

jkalias commented 1 year ago

I try to avoid doube[] initializers in the library as much as possible, in order to keep the API surface as small, coherent and independent (Math.Numerics...) as possible. What is the reason you think we need these here?

jkalias commented 1 year ago

After the discussion in #229 and the reverted changes, we might have to revisit the comments here

jkalias commented 1 year ago

Could you please split this PR into two distinct ones? The one containing only the additional functions, and another containing the new Arc2D class? It would then be easier to separate the concerns