mathnet / mathnet-spatial

Math.NET Spatial
http://spatial.mathdotnet.com
MIT License
376 stars 132 forks source link

Version 0.7.0 not available on Nuget #233

Open mymike00 opened 1 year ago

mymike00 commented 1 year ago

Hi all, I see that recently a new version of the library has been released and the documentation on the website targets version 0.7.0, which isn't available on NuGet. I would need it for the new function Plane.BestFit. I also tried to build it myself but I had some troubles. Having the new version on NuGet would definitely be simpler for everyone.

I hope you can consider my request soon. Thank you very much for your work!

jkalias commented 1 year ago

Hi,

I have tried several times to notify the official maintainers of this repo to update the Nuget feed (I was recently accepted as a co-maintainer on the project), however I received no feedback.

mymike00 commented 1 year ago

Oh, that's a pity... I recently just started using this library but seems very cool and some functions are really handy. Anyway, would you be able to load the DLLs of v0.7.0 as a Release here on github? It would make it simpler for people to use it instead of building by themselves (which I think I managed to do it btw)

jkalias commented 1 year ago

I have never tried to publish any NuGet package, so be gentle :) Try this and let me know if you are missing something.

mymike00 commented 1 year ago

I can't see any release at the page you linked. Anyway, I managed to build and link my project against latest version on main and managed to try the Plane.BestFit() function (which was what I was interested in) ...aand I don't think it could work for my scenario: with a reasonable number of points it seems to work fine, but I need to perform that on a depth image, which would be 1 million points and attempting that saturates my ram taking 17 GB and crashes the program. Should I open a separate issue for this one? Do you think more details are needed, or these informations are just fine to start with? I'll may provide an MRE too So, sorry for the noise, but I'm less interested in the latest version being published. But if you still want to do it I'm glad to help you test whatever you need. Thank you again!

jkalias commented 1 year ago

Here is the link again https://github.com/jkalias/mathnet-spatial/releases

jkalias commented 1 year ago

A test case which crashes would be deeply appreciated it, with all data provided. Perhaps set up as a unit test (?)

mymike00 commented 1 year ago

I still see an empty release page... I thought to just share my code, but a draft PR with a unit test seems better. Hope to find some time soon