mathnet / mathnet-spatial

Math.NET Spatial
http://spatial.mathdotnet.com
MIT License
376 stars 132 forks source link

Bug in BaseChangeMatrix, TransformFromCoordSys, TransformToCoordSys #236

Open fairendil opened 9 months ago

fairendil commented 9 months ago

The bug occurred when calculating the BaseChangeMatrix and a copy of the coordinate system was rotated instead of the base coordinate system rotation. This resulted in the OffsetToBase being added twice, causing an issue in the transformation process.

jkalias commented 9 months ago

Can you provide a regression unit test case for this bug fix please?

jkalias commented 2 months ago

@fairendil is this still relevant?

fairendil commented 2 months ago

No. It's still working wrong and we are using Transform(Point3D/Vector3D)

jkalias commented 2 months ago

No. It's still working wrong and we are using Transform(Point3D/Vector3D)

So it IS relevant if it’s still wrong, correct? Would you mind including some regression unit tests for this case?