mathnet / mathnet-symbolics

Math.NET Symbolics
http://symbolics.mathdotnet.com
MIT License
341 stars 66 forks source link

Implicit Operator in Expression #26

Closed FoggyFinder closed 7 years ago

FoggyFinder commented 7 years ago

Is there a need for the existence of the Implicit Operator for string in Expression?

https://github.com/mathnet/mathnet-symbolics/blob/96a21c9c2413a080daff7dc3943a22f8b80179b3/src/Symbolics/Expression.fs#L485

As this may lead to weird results

For example:

            string example = "1a/)";
            Expression test = example;
            Console.WriteLine(Infix.Format(test)); // => 1a/)
            Console.WriteLine(LaTeX.Format(test)); // => {1a/)}
cdrnet commented 7 years ago

I understand why I added it, but in retrospect I agree that it was a bad idea. We better drop it.