Necessity of the module NumericLiteralQ

mathnet / mathnet-symbolics

Math.NET Symbolics

http://symbolics.mathdotnet.com

MIT License

341 stars 66 forks source link

Necessity of the module NumericLiteralQ #51

Closed FoggyFinder closed 6 years ago

FoggyFinder commented 6 years ago

I'm not sure in target of the module NumericLiteralQ.

The four from five functions is duplicate from the module Operators

The last one function FromString is simple, so maybe better just remove this module?

cdrnet commented 6 years ago

The point of this module is to allow the 4Q notation directly in F# source code (F# compiler conventions). The module is not intended to be used by other means.

FoggyFinder commented 6 years ago

Oh, really - I had to check before creating issue...

cdrnet commented 6 years ago

I guess a code comment at that module explaining its purpose would not be wrong, especially since it involves "compiler magic" :)