Closed BunkerCoder closed 3 years ago
Realize that I made a fundamental mistake, and Type needs to return P (summary) or Q (update), not just Q. Need to refactor to make this solution work. @mathpaquette - Will you pull if I get this right, or should we wait for #107?
Realize that I made a fundamental mistake, and Type needs to return P (summary) or Q (update), not just Q. Need to refactor to make this solution work. @mathpaquette - Will you pull if I get this right, or should we wait for #107?
Ah you just closed it?? I think we should get the fix ASAP and merge. Will still need to support until next major release.
Yes - Just closed now. It doesn't break, it just doesn't return Type=P when the message is a summary message.
Yes - Just closed now. It doesn't break, it just doesn't return Type=P when the message is a summary message. I can wait your other commit. no stress.
Didn't need to refactor - just fix parsing.
Didn't need to refactor - just fix parsing.
Are you confident now :) hehe
Hard to be confident after stupid brain flatulence like that, but, Yes...
fixes #104