search

mathpaquette / IQFeed.CSharpApiClient

IQFeed.CSharpApiClient is fastest and the most well-designed C# DTN IQFeed socket API connector available
MIT License
120 stars 43 forks source link

Fix handling of Dynamic Field: Type #110

Closed BunkerCoder closed 3 years ago

BunkerCoder commented 3 years ago

fixes #104

BunkerCoder commented 3 years ago

Realize that I made a fundamental mistake, and Type needs to return P (summary) or Q (update), not just Q. Need to refactor to make this solution work. @mathpaquette - Will you pull if I get this right, or should we wait for #107?

mathpaquette commented 3 years ago

Realize that I made a fundamental mistake, and Type needs to return P (summary) or Q (update), not just Q. Need to refactor to make this solution work. @mathpaquette - Will you pull if I get this right, or should we wait for #107?

Ah you just closed it?? I think we should get the fix ASAP and merge. Will still need to support until next major release.

BunkerCoder commented 3 years ago

Yes - Just closed now. It doesn't break, it just doesn't return Type=P when the message is a summary message.

mathpaquette commented 3 years ago

Yes - Just closed now. It doesn't break, it just doesn't return Type=P when the message is a summary message. I can wait your other commit. no stress.

BunkerCoder commented 3 years ago

Didn't need to refactor - just fix parsing.

mathpaquette commented 3 years ago

Didn't need to refactor - just fix parsing.

Are you confident now :) hehe

BunkerCoder commented 3 years ago

Hard to be confident after stupid brain flatulence like that, but, Yes...