PeriodVolume doesn't fit in 32 bit integer of IntervalMessage

[samushenkov]

Hey there.

Some 4-hour candles for C (CITIGROUP) have period volume that doesn't fit in 32 bit integer field of IntervalMessage. This causes other various problems depending on used API method.

[mathpaquette]

@samushenkov could you please include requests you used?

[samushenkov]

I am not sure about exact time period, so try something like this:

var dateFrom = new DateTime(2000, 01, 01, 0, 0, 0);
var dateTo = new DateTime(2021, 04, 22, 0, 0, 0);

var interval = 3600 * 4;

var maxDatapoints = 50000;

var candles = await lookupClient.Historical.GetHistoryIntervalTimeframeAsync("C", interval, dateFrom, dateTo, maxDatapoints: maxDatapoints, dataDirection: DataDirection.Newest, labelAtBeginning: LabelAtBeginning.Beginning);

[mathpaquette]

@samushenkov are you getting InvalidData or app crash ?

[samushenkov]

It depends on used api method.

Without request id: GetHistoryIntervalTimeframeAsync throws InvalidData exception. And the next subsequent request to the same SocketClient returns candles from the first request.

With request id: Calling GetHistoryIntervalTimeframeAsync will end in app crash. It is not possible to handle exception.

[mathpaquette]

got it thanks.

[mathpaquette]

@samushenkov super helpful all your issues/comments

[samushenkov]

Thanks

[mathpaquette]

@samushenkov please have a look to my PR.

[mathpaquette]

@samushenkov can you confirm its fine now.

[samushenkov]

Hey @mathpaquette, thank you for your work! I will check when have a free minute.

[mathpaquette]

@samushenkov please dont forget to star us :)