search

mathpaquette / IQFeed.CSharpApiClient

IQFeed.CSharpApiClient is fastest and the most well-designed C# DTN IQFeed socket API connector available
MIT License
120 stars 43 forks source link

fix(lookup): properly throw for InvalidData #125

Closed mathpaquette closed 3 years ago

mathpaquette commented 3 years ago

fixes #122, fixes #124

mathpaquette commented 3 years ago

@NichUK @mrut2pac not sure it makes sense to change PeriodVolume int32 to long for this kind of unique edge case expressed by #122

NichUK commented 3 years ago

To be honest, I think that it does make sense. Bar volumes can get awfully big for bars of any significant length.

mrut2pac commented 3 years ago

I second that. In my applications I always use long for volume. Especially reasonable for penny & sub-penny stocks :)

mathpaquette commented 3 years ago

To be honest, I think that it does make sense. Bar volumes can get awfully big for bars of any significant length.

well, its very exceptional I will say and it does happen only when you set large interval such 4 hours on very very active stocks.

mathpaquette commented 3 years ago

I second that. In my applications I always use long for volume. Especially reasonable for penny & sub-penny stocks :)

okay lets move to long for IntervalMessage.PeriodVolume as well.

Thanks guys.

mathpaquette commented 3 years ago

@NichUK any comments?