search

mathpaquette / IQFeed.CSharpApiClient

IQFeed.CSharpApiClient is fastest and the most well-designed C# DTN IQFeed socket API connector available
MIT License
120 stars 43 forks source link

Issue #17 Fix #18

Closed hunterfries closed 6 years ago

hunterfries commented 6 years ago

Reversed Open and Close position in IntervalMessage and DailyWeeklyMonthlyMessage objects

hunterfries commented 6 years ago

Hey can we release 1.4.1 so I can get this fix from nuget?

On Aug 9, 2018, at 5:29 PM, Mathieu Paquette notifications@github.com wrote:

Merged #18 https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#event-1781238045, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icJqUprR4YBCYd3UispY6395u9Kaaks5uPKnNgaJpZM4V1-xX.

mathpaquette commented 6 years ago

Hunter, check the appveyor build log, packages are deployed automatically on myget

Sent from my iPhone

On Aug 9, 2018, at 6:29 PM, hunterfries notifications@github.com<mailto:notifications@github.com> wrote:

Hey can we release 1.4.1 so I can get this fix from nuget?

On Aug 9, 2018, at 5:29 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com> wrote:

Merged #18 https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#event-1781238045, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icJqUprR4YBCYd3UispY6395u9Kaaks5uPKnNgaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411918323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN7lOQmQl4jqcWIL0UQwUUg7w3WRVks5uPLe2gaJpZM4V1-xX.

hunterfries commented 6 years ago

I removed and readded the package and the dll is still showing an 8/5 build date..am i missing something?

On Aug 9, 2018, at 7:19 PM, Mathieu Paquette notifications@github.com wrote:

Hunter, check the appveyor build log, packages are deployed automatically on myget

Sent from my iPhone

On Aug 9, 2018, at 6:29 PM, hunterfries notifications@github.com<mailto:notifications@github.com> wrote:

Hey can we release 1.4.1 so I can get this fix from nuget?

On Aug 9, 2018, at 5:29 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com> wrote:

Merged #18 https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#event-1781238045, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icJqUprR4YBCYd3UispY6395u9Kaaks5uPKnNgaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411918323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN7lOQmQl4jqcWIL0UQwUUg7w3WRVks5uPLe2gaJpZM4V1-xX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411927952, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icBjE9ciixlWoPp9vv-7kekMZ-qMXks5uPMN3gaJpZM4V1-xX.

mathpaquette commented 6 years ago

Try this please:

Install-Package IQFeed.CSharpApiClient -Version 1.4.0.151 -Source https://www.myget.org/F/inovitex/api/v3/index.json

Mathieu

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: hunterfries notifications@github.com Sent: Thursday, August 9, 2018 7:50:07 PM To: mathpaquette/IQFeed.CSharpApiClient Cc: Mathieu Paquette; State change Subject: Re: [mathpaquette/IQFeed.CSharpApiClient] Issue #17 Fix (#18)

I removed and readded the package and the dll is still showing an 8/5 build date..am i missing something?

On Aug 9, 2018, at 7:19 PM, Mathieu Paquette notifications@github.com wrote:

Hunter, check the appveyor build log, packages are deployed automatically on myget

Sent from my iPhone

On Aug 9, 2018, at 6:29 PM, hunterfries notifications@github.com<mailto:notifications@github.com> wrote:

Hey can we release 1.4.1 so I can get this fix from nuget?

On Aug 9, 2018, at 5:29 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com> wrote:

Merged #18 https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#event-1781238045, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icJqUprR4YBCYd3UispY6395u9Kaaks5uPKnNgaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411918323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN7lOQmQl4jqcWIL0UQwUUg7w3WRVks5uPLe2gaJpZM4V1-xX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411927952, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icBjE9ciixlWoPp9vv-7kekMZ-qMXks5uPMN3gaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411932954, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN1L96w1xz7dwUY7Vpwtqsy-tTxE0ks5uPMqvgaJpZM4V1-xX.

hunterfries commented 6 years ago

Thanks dude. We are good to go. Does nuget just take some time to update? Sorry for the back and forth and sense of urgency…fixing this was in the critical path..thanks for the rapid response!

hunter

On Aug 9, 2018, at 8:28 PM, Mathieu Paquette notifications@github.com wrote:

Try this please:

Install-Package IQFeed.CSharpApiClient -Version 1.4.0.151 -Source https://www.myget.org/F/inovitex/api/v3/index.json

Mathieu

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: hunterfries notifications@github.com Sent: Thursday, August 9, 2018 7:50:07 PM To: mathpaquette/IQFeed.CSharpApiClient Cc: Mathieu Paquette; State change Subject: Re: [mathpaquette/IQFeed.CSharpApiClient] Issue #17 Fix (#18)

I removed and readded the package and the dll is still showing an 8/5 build date..am i missing something?

On Aug 9, 2018, at 7:19 PM, Mathieu Paquette notifications@github.com wrote:

Hunter, check the appveyor build log, packages are deployed automatically on myget

Sent from my iPhone

On Aug 9, 2018, at 6:29 PM, hunterfries notifications@github.com<mailto:notifications@github.com> wrote:

Hey can we release 1.4.1 so I can get this fix from nuget?

On Aug 9, 2018, at 5:29 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com> wrote:

Merged #18 https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#event-1781238045, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icJqUprR4YBCYd3UispY6395u9Kaaks5uPKnNgaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411918323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN7lOQmQl4jqcWIL0UQwUUg7w3WRVks5uPLe2gaJpZM4V1-xX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411927952, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icBjE9ciixlWoPp9vv-7kekMZ-qMXks5uPMN3gaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411932954, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN1L96w1xz7dwUY7Vpwtqsy-tTxE0ks5uPMqvgaJpZM4V1-xX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411938899, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icB4m48cFwS_NZf3_0vQIa2R9yf2fks5uPNOmgaJpZM4V1-xX.

mathpaquette commented 6 years ago

Welcome Hunter.

In fact, every commits generate a package on myget.. Releases on Nuget are only triggered by merge on the release branch on version increase.

I try to keep as low as possible the number of release on Nuget since we cant really remove them and this generate a lot of mess for the end user 😊

Happy that you appreciate the effort. Mathieu

From: hunterfries notifications@github.com Sent: August 9, 2018 9:25 PM To: mathpaquette/IQFeed.CSharpApiClient IQFeed.CSharpApiClient@noreply.github.com Cc: Mathieu Paquette m.paquette@inovitex.com; State change state_change@noreply.github.com Subject: Re: [mathpaquette/IQFeed.CSharpApiClient] Issue #17 Fix (#18)

Thanks dude. We are good to go. Does nuget just take some time to update? Sorry for the back and forth and sense of urgency…fixing this was in the critical path..thanks for the rapid response!

hunter

On Aug 9, 2018, at 8:28 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com> wrote:

Try this please:

Install-Package IQFeed.CSharpApiClient -Version 1.4.0.151 -Source https://www.myget.org/F/inovitex/api/v3/index.json

Mathieu

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows 10

From: hunterfries notifications@github.com<mailto:notifications@github.com> Sent: Thursday, August 9, 2018 7:50:07 PM To: mathpaquette/IQFeed.CSharpApiClient Cc: Mathieu Paquette; State change Subject: Re: [mathpaquette/IQFeed.CSharpApiClient] Issue #17 Fix (#18)

I removed and readded the package and the dll is still showing an 8/5 build date..am i missing something?

On Aug 9, 2018, at 7:19 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com> wrote:

Hunter, check the appveyor build log, packages are deployed automatically on myget

Sent from my iPhone

On Aug 9, 2018, at 6:29 PM, hunterfries notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:

Hey can we release 1.4.1 so I can get this fix from nuget?

On Aug 9, 2018, at 5:29 PM, Mathieu Paquette notifications@github.com<mailto:notifications@github.com<mailto:notifications@github.com%3cmailto:notifications@github.com>> wrote:

Merged #18 https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18 into master.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#event-1781238045, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icJqUprR4YBCYd3UispY6395u9Kaaks5uPKnNgaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411918323, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN7lOQmQl4jqcWIL0UQwUUg7w3WRVks5uPLe2gaJpZM4V1-xX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411927952, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icBjE9ciixlWoPp9vv-7kekMZ-qMXks5uPMN3gaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411932954, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN1L96w1xz7dwUY7Vpwtqsy-tTxE0ks5uPMqvgaJpZM4V1-xX. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411938899, or mute the thread https://github.com/notifications/unsubscribe-auth/Ad2icB4m48cFwS_NZf3_0vQIa2R9yf2fks5uPNOmgaJpZM4V1-xX.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/18#issuecomment-411947159, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN5DlzhFWvYMgdfZfIknUNsc9Qqycks5uPOEGgaJpZM4V1-xX.