Closed Nucs closed 6 years ago
@Nucs are you sure that the serialization will work with not setters? I had this issue yesterday.
You are right, I haven't noticed that. properties do not have a public setter. This might indeed be an issue.
Should I just make all empty constructors public and add a public setter to all properties to widen the support to almost any serialization library?
Nope this will break immutability...
Sent from my iPhone
On Aug 24, 2018, at 12:26 PM, Eli Belash notifications@github.com<mailto:notifications@github.com> wrote:
You are right, I haven't noticed that. properties do not have a public setter. This might indeed be an issue.
Should I just make all empty constructors public and add a public setter to all properties to widen the support to almost any serialization library?
— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/22#issuecomment-415811042, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AEKBN5OOJ10T52qssDxn2Ug2orO9YJnIks5uUClIgaJpZM4WLPnQ.
Awaiting for you to decide what to do.
We're going to postpone this one...
See Issue #11.