feat(lookup/symbol): add support for symbol lookup

mrut2pac commented 5 years ago

Hope this will work :)

mathpaquette commented 5 years ago

nice!

mathpaquette commented 5 years ago

What do you think of this…

Easier to read and test. We will be able to cover all branching pretty easily

[cid:image001.png@01D57BB8.A47D4650]

From: mrut2pac notifications@github.com Sent: October 5, 2019 3:30 PM To: mathpaquette/IQFeed.CSharpApiClient IQFeed.CSharpApiClient@noreply.github.com Cc: Mathieu Paquette me@mathpaquette.com; Comment comment@noreply.github.com Subject: Re: [mathpaquette/IQFeed.CSharpApiClient] feat(lookup/symbol): add support for symbol lookup (#47)

@mrut2pac commented on this pull request.

using IQFeed.CSharpApiClient.Common;

using IQFeed.CSharpApiClient.Extensions;

namespace IQFeed.CSharpApiClient.Lookup.Common

{

 public abstract class BaseLookupMessageHandler

 {

private static readonly string EndMessagePattern = IQFeedDefault.ProtocolEndOfMessageCharacters + IQFeedDefault.ProtocolDelimiterCharacter;
private static readonly string NoDataIndicator = "E,!NO_DATA!";
private static readonly Regex ErrorPattern = new Regex(@"^E,.*,$");
private static readonly Regex ErrorPatternWithRequestId = new Regex(@"^.,E,.,$");
private static readonly string EndMessagePattern = IQFeedDefault.ProtocolEndOfMessageCharacters + IQFeedDefault.ProtocolDelimiterCharacter;

 protected static MessageContainer<T> ProcessMessages<T>(Func<string, T> parser, byte[] message, int count, bool hasRequestId)

agreed

mathpaquette / IQFeed.CSharpApiClient