Closed mrut2pac closed 5 years ago
nice!
What do you think of this…
Easier to read and test. We will be able to cover all branching pretty easily
[cid:image001.png@01D57BB8.A47D4650]
From: mrut2pac notifications@github.com Sent: October 5, 2019 3:30 PM To: mathpaquette/IQFeed.CSharpApiClient IQFeed.CSharpApiClient@noreply.github.com Cc: Mathieu Paquette me@mathpaquette.com; Comment comment@noreply.github.com Subject: Re: [mathpaquette/IQFeed.CSharpApiClient] feat(lookup/symbol): add support for symbol lookup (#47)
@mrut2pac commented on this pull request.
In src/IQFeed.CSharpApiClient/Lookup/Common/BaseLookupMessageHandler.cshttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/47#discussion_r331759076:
using IQFeed.CSharpApiClient.Common;
using IQFeed.CSharpApiClient.Extensions;
namespace IQFeed.CSharpApiClient.Lookup.Common
{
public abstract class BaseLookupMessageHandler
{
private static readonly string EndMessagePattern = IQFeedDefault.ProtocolEndOfMessageCharacters + IQFeedDefault.ProtocolDelimiterCharacter;
private static readonly string NoDataIndicator = "E,!NO_DATA!";
private static readonly Regex ErrorPattern = new Regex(@"^E,.*,$");
private static readonly Regex ErrorPatternWithRequestId = new Regex(@"^.,E,.,$");
private static readonly string EndMessagePattern = IQFeedDefault.ProtocolEndOfMessageCharacters + IQFeedDefault.ProtocolDelimiterCharacter;
protected static MessageContainer<T> ProcessMessages<T>(Func<string, T> parser, byte[] message, int count, bool hasRequestId)
agreed
— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/mathpaquette/IQFeed.CSharpApiClient/pull/47?email_source=notifications&email_token=ABBICNZ32XEDPIQUDXESN4LQNDTLVA5CNFSM4I44V3YKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCHACN3Q#discussion_r331759076, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ABBICN63P7POVY5JYO7APNLQNDTLVANCNFSM4I44V3YA.
Hope this will work :)