search

mathpaquette / IQFeed.CSharpApiClient

IQFeed.CSharpApiClient is fastest and the most well-designed C# DTN IQFeed socket API connector available
MIT License
121 stars 42 forks source link

create a Docker image to be able to run Integration Tests when creating a PR #48

Closed mathpaquette closed 4 years ago

mathpaquette commented 5 years ago

anyone interested ?

flerka commented 5 years ago

@mathpaquette Hi! I'm interested, from what I've understood it must be multistage dockerfile with 1st stage that copies and complies integration test project and second stage that runs integration test using that compiled code?

mathpaquette commented 5 years ago

Hello @flerka thank you for your interest! The issue right now, we can only run unit tests because integration tests require IQFEED CLIENT to be installed on the Continuous Integration server. I think it would be possible to create a Docker file that will pull IQFeed Client and integration tests will be executed in it. I think the first step will be to check if AppVeyor is supporting such setup.

hfries commented 4 years ago

@mathpaquette do you have a preferred method of storing / injecting creds to run the integration tests? I have the dockerfile built, but NotSupportedException being thrown when running tests against netcore 2.0. I'll put up a pr for review / discussion later this week.

mathpaquette commented 4 years ago

@hfries afterthought this might be more cumbersome than very helpful. Do you plan to use it in any ways?

hunterfries commented 4 years ago

@mathpaquette I'm game to put something up if anyone sees value in it. I don't think I would use it since my dev env would have iq connect installed, but if we wanted to ensure some level of consistency to the tests, containerizing the tests would check the box.